Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor bug while trimming hash, test added #435

Merged
merged 4 commits into from
Dec 23, 2024
Merged

fix: minor bug while trimming hash, test added #435

merged 4 commits into from
Dec 23, 2024

Conversation

Mohiiit
Copy link
Contributor

@Mohiiit Mohiiit commented Dec 20, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix

What is the current behavior?

Resolves: #NA

What is the new behavior?

  • it was failing when hash is 0x0 which is possible in case of the appchains

Does this introduce a breaking change?

No

Other information

jbcaron
jbcaron requested changes Dec 20, 2024
View reviewed changes
Copy link
Member

@jbcaron jbcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to directly use the function mc-sync::utils::trim_hash and move it directly into mp-utils or mp-convert

@Mohiiit Mohiiit self-assigned this Dec 21, 2024
@antiyro antiyro merged commit 47b5031 into main Dec 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbcaron jbcaron jbcaron approved these changes

@antiyro antiyro antiyro approved these changes

Assignees

@Mohiiit Mohiiit

Labels
None yet
Projects
Madara
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mohiiit @antiyro @jbcaron