Allow ELOK to leak some memory instead of crashing on reload after wi…

…ndow.open (#123)
macro-inc · Feb 1, 2024 · 29def8d · 29def8d
2 parents e643c6c + 5851d8f
commit 29def8d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/src/electron/ELECTRON_VERSION b/src/electron/ELECTRON_VERSION
@@ -1 +1 @@
-20.3.0-rc18
+20.3.0-rc19
diff --git a/src/electron/office/office_client.cc b/src/electron/office/office_client.cc
@@ -56,9 +56,6 @@ v8::Local<v8::Value> OfficeClient::GetHandle(v8::Isolate* isolate) {
   return self_.Get(isolate);
 }
 
-// static
-base::AtomicRefCount g_client_counter{0};
-
 // instance
 namespace {
 static void GetOfficeHandle(v8::Local<v8::Name> name,
@@ -98,7 +95,6 @@ void OfficeClient::InstallToContext(v8::Local<v8::Context> context) {
   }
   client->self_.Reset(isolate, wrapper);
   lazy_tls->Set(std::move(client));
-	g_client_counter.Increment();
 
   context->Global()
       ->SetAccessor(
@@ -118,10 +114,6 @@ void OfficeClient::RemoveFromContext(v8::Local<v8::Context> /*context*/) {
   if (lazy_tls->Get())
     lazy_tls->Get()->Unset();
   lazy_tls->Set(nullptr);
-
-	if (!g_client_counter.Decrement()) {
-		OfficeInstance::Unset();
-	}
 }
 
 OfficeClient::OfficeClient()