-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option for inline-comment-spaces for toml #205
Add an option for inline-comment-spaces for toml #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the extension.
I do apologise for the long time for the review
I'll be taking care of rebasing the change and removing the not needed file before merging this.
test-data/pretty_format_toml/inline-comment-2spaces-pretty-formatted copy.toml
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
I used github.dev to create the PR and therefore could not test it, which is why 2 errors sneaked into the tests. I hope that all errors have now been fixed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 333 334 +1
=========================================
+ Hits 333 334 +1 ☔ View full report in Codecov by Sentry. |
I used github.dev to create the PR and therefore could not test it, which is why 2 errors sneaked into the tests. I hope that all errors have now been fixed. @alkatar21 no worries ... it is all good. |
Based on your #185 (comment) I have now created a pull request to add this option.
What is the reason for the flag:
I use the Even Better TOML VSCode extension in my project, which has no option to set this. To streamline the tools, I think it's easiest to add the option here.
I have extended #160 for the implementation. Let me know if you come up with any better names.
Hint: I have not executed the code locally, but I assume the tests run once after the approvel in the CI?