Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for inline-comment-spaces for toml #205

Merged
merged 4 commits into from
Mar 31, 2024

Conversation

alkatar21
Copy link
Contributor

@alkatar21 alkatar21 commented Dec 27, 2023

Based on your #185 (comment) I have now created a pull request to add this option.

What is the reason for the flag:
I use the Even Better TOML VSCode extension in my project, which has no option to set this. To streamline the tools, I think it's easiest to add the option here.

I have extended #160 for the implementation. Let me know if you come up with any better names.

Hint: I have not executed the code locally, but I assume the tests run once after the approvel in the CI?

@alkatar21 alkatar21 changed the title Add an option for inline-comment-spaces Add an option for inline-comment-spaces for toml Dec 27, 2023
@macisamuele macisamuele reopened this Mar 24, 2024
Copy link
Owner

@macisamuele macisamuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the extension.

I do apologise for the long time for the review

I'll be taking care of rebasing the change and removing the not needed file before merging this.

@macisamuele macisamuele enabled auto-merge March 29, 2024 21:20
auto-merge was automatically disabled March 31, 2024 11:27

Head branch was pushed to by a user without write access

@alkatar21
Copy link
Contributor Author

I used github.dev to create the PR and therefore could not test it, which is why 2 errors sneaked into the tests. I hope that all errors have now been fixed.

@alkatar21 alkatar21 requested a review from macisamuele March 31, 2024 11:33
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (97a46d9) to head (39e67c5).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #205   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          333       334    +1     
=========================================
+ Hits           333       334    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macisamuele
Copy link
Owner

I used github.dev to create the PR and therefore could not test it, which is why 2 errors sneaked into the tests. I hope that all errors have now been fixed.

@alkatar21 no worries ... it is all good.
I was just about to checkout the PR and have it fixed such that within the day I could have released the new version including this.

@macisamuele macisamuele enabled auto-merge March 31, 2024 16:58
@macisamuele macisamuele merged commit 86cdd95 into macisamuele:master Mar 31, 2024
50 checks passed
@alkatar21 alkatar21 deleted the inline-comment-spaces branch April 12, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants