Linting rebased #174
Merged
Linting rebased #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mably here is my PR rebased, I closed the other one. Thanks for your patience :) With regards to bugs in functionality, would you mind writing the list of bugs you found in a ticket? I have been playing around with the client and I could not see any 5xx or stacktraces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #165, #175
Deprecates #169
What does this PR do
ESLintfor checking style and automatically fixing minor errorsapp/lightningandapp/routesHow to review this PR
I'm happy to re-evaluate how we check style, if you have any questions let's start a thread on this PR