Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sockid to Close #129

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add sockid to Close #129

wants to merge 2 commits into from

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented May 3, 2021

tcp-info is already caching the SockID for connections, so should send it with the Close events, instead of requiring clients to cache it too.


This change is Reviewable

@gfr10598 gfr10598 requested a review from stephen-soltesz May 3, 2021 15:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 918

  • 11 of 13 (84.62%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 82.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inetdiag/structs.go 2 3 66.67%
saver/saver.go 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
inetdiag/structs.go 1 95.69%
saver/saver.go 1 75.3%
Totals Coverage Status
Change from base Build 911: -0.2%
Covered Lines: 1084
Relevant Lines: 1310

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't object to this change. Please enumerate the number of other repos that will want to be updated to use the latest interface. gomod should help pin existing users, but if it's something we can just do quickly to get it out of the way all the better.

Reviewable status: 0 of 1 LGTMs obtained

@SaiedKazemi SaiedKazemi changed the base branch from master to main August 11, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants