Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland Layer Shell #2048

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Conversation

gfgit
Copy link
Member

@gfgit gfgit commented Apr 8, 2024

This was extracted from #2043

layer_shell protocol allows to ask for placement on Wayland
TODO: after changing length to pixels and back to percent
alignment is ignored and always kept to right
Set layer shell keyboard interactivity on-demand
panel/lxqtpanel.cpp Outdated Show resolved Hide resolved
panel/lxqtpanel.cpp Outdated Show resolved Hide resolved
@gfgit gfgit mentioned this pull request Apr 9, 2024
@gfgit
Copy link
Member Author

gfgit commented Apr 9, 2024

Ok so remaining issue should be:

  1. Panel auto-hide: here on KWin it does not let me click on bottom parts of apps (like statusbar) because panel fires on top and mouse click ends up on the panel
  2. Percent lengths are glitchy here

@tsujan
Copy link
Member

tsujan commented Apr 9, 2024

Ok so remaining issue should be:...

Do you intend to fix them here, or do you prefer to do it in another PR, after this one is merged? I have no problem with either.

@gfgit
Copy link
Member Author

gfgit commented Apr 9, 2024

Well I've already tried investigating but with no luck so far so maybe merging could be better so more people test the code.

@tsujan
Copy link
Member

tsujan commented Apr 9, 2024

OK. I'll merge it tonight, after taking another look. Thanks!

Copy link
Member

@tsujan tsujan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM.

@tsujan tsujan merged commit 32cb146 into lxqt:master Apr 9, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants