Wayland taskbar support #2031

gfgit · 2024-02-24T10:17:52Z

Depends on #2024 (Qt6 port) and #2029 (WM abstraction)

This is an experimental implementation on taskbar, desktopswitch and showdesktop functionality for KWin Wayland compositor.
It uses following protocols:

org-kde-plasma-virtual-desktop
plasma-window-management
(Taken from plasma-wayland-protocols repository)

Code is inspired by libtaskmanager/waylandtasksmodel.cpp

Ideally the Wayland backend should have sub-backends targeting specific compositors when no standard protocol is available.

It also uses layer shell protocol to place panel on screen edge.

NOTE: panel auto-hide is not working yet

Fixes CMake error

stefonarch · 2024-02-24T13:22:45Z

Heureka!

In plasma session all 3 elements of lxqt-panel are working perfectly ;) just starting from cli.

Less luck in openbox with kwin nested session (both cli and .desktop file in /usr/share/applications)

taskbar empty
desktop switch working
showdesktop segfaults panel, sorry only screenshot

Maybe kwin needs more arguments, --no-kactivities and else.

stefonarch · 2024-02-24T14:51:52Z

NOTE: panel auto-hide is not working yet

On my slower VM (neon-unstable) this works, but empty taskbar also in plasma-session
EDIT: works also on the dev edition.

gfgit · 2024-02-24T14:59:37Z

showdesktop segfaults panel, sorry only screenshot

Protocol access is not guarded yet.
Infact we should wait for compositor to grant the protocol before starting using it. in your case I think the protocol is not grabted (hence taskbar empty) and you explicitly use make a request to show desktop which fails.
Need to investigate why nested session does not grant protocol

stefonarch · 2024-02-24T15:15:53Z

I fiddled with env vars (see featherpad window) and.... all working, also showdesktop amd autohide! Not sure which one is needed and about the Qt one. Some invisible icon issues, the share dir doesn't work here.

gfgit · 2024-02-24T15:53:07Z

In kwin_wayland nested inside openbox I can reproduce crash if clicking show desktop button.
Crash does not happen if I set KWIN_WAYLAND_NO_PERMISSION_CHECKS=1 env variable before starting KWin.
Also FancyMenu is completely empty and also Favorites and All Apps categories are empty and without icon. I think XDG env variables are not set correctly

stefonarch · 2024-02-24T16:19:27Z

Also FancyMenu is completely empty and also Favorites and All Apps categories are empty and without icon. I think XDG env variables are not set correctly

Here I didn't install wip_qt6 of lxqt-qtplugin yet.

I'm using this script to start openbox at the bottom line exec openbox and inserted those 3 env vars too. The I use just kwin_wayland lxqt-panel. For some reason if I try directly form sddm to start a kwin script I've no cursor. I'm happy when I can stop using Neon for testing...

stefonarch · 2024-02-24T16:30:45Z

Found only one issue: the favorites dialog is normal window and behind, and similar for plugin directorymenu: it displays a window center screen.

Disabled also all kwin effects, now it's snappy.

stefonarch · 2024-02-24T17:17:55Z

Just for the record: Only export XDG_SESSION_DESKTOP=KDE is needed for a working taskbar. And also "mount" plugin opens a normal window center screen, looks like a layer-shell-qt bug to me as it doesn't happen without.

EDIT: seems a focus thing, if typing in the search first the favorites menu is adiacent at the panel:

Another misalignment with bottom panel:

stefonarch · 2024-02-24T18:47:14Z

Testing with labwc, no popup is shown as normal window, but some misalignment can be found, like the favorites menu close to the panel or directorymenu covering the panel on the right. AND: autohide working!

labwc.mp4

Crash when clicking showdesktop is here present too.

gfgit · 2024-02-25T11:34:32Z

Only export XDG_SESSION_DESKTOP=KDE is needed

Not working here :(

EDIT: It works, I was using an old .desktop file

XDG_CURRENT_DESKTOP=KDE makes it load icons from breeze theme using KDE Platform integration (I still have to install lxqt qtplugin which would replace this)

XDG_SESSION_DESKTOP=KDE is needed because .desktop file contains OnlyShowId=KDE

XDG_MENU_PREFIX=lxqt- makes FancyMenu load the applications

I have same popup issues and also "Open With" both from dolphin and from PCManFM-Qt does not work

gfgit · 2024-02-25T12:28:59Z

For future works:
I've found this code inside Qt sources:

QPlatformServiceColorPicker *QGenericUnixServices::colorPicker(QWindow *parent)
{
#if QT_CONFIG(dbus)
    // Make double sure that we are in a wayland environment. In particular check
    // WAYLAND_DISPLAY so also XWayland apps benefit from portal-based color picking.
    // Outside wayland we'll rather rely on other means than the XDG desktop portal.
    if (!qEnvironmentVariableIsEmpty("WAYLAND_DISPLAY")
        || QGuiApplication::platformName().startsWith("wayland"_L1)) {
        return new XdgDesktopPortalColorPicker(portalWindowIdentifier(parent), parent);
    }
    return nullptr;
#else
    Q_UNUSED(parent);
    return nullptr;
#endif
}

So we could replace out color picker logic with XDG Portal equivalent

stefonarch · 2024-02-25T18:27:51Z

"Open With" both from dolphin and from PCManFM-Qt does not work

No issue here with both filemanager.

stefonarch · 2024-02-25T18:59:13Z

Launching lxqt-globalkeysd default shortcut Alt+F1 is opening the panel menu, but can't be changed obviously. Kwin-only.

gfgit · 2024-02-26T08:50:57Z

Color picker now uses XDG Desktop Portal on Wayland. Pasting color to clipboard does not seem to work yet.
Also we should show some sort of error if portal says color picking is not supported of if no portal is available at all.
Logic is already implemented, we just need the UI part

stefonarch · 2024-02-26T11:35:09Z

Pasting color to clipboard does not seem to work yet.

Usually this is piped to wl-copy, to take inspiration.

stefonarch · 2024-02-26T11:36:25Z

I noticed that kwin has no "shade" (roll up) feature anymore, I thought it was possible once. Only lawc has it afaik.

StatusNotifierButton: switch to dbusmenu-lxqt

- Now returns floating point QPointF, should we keep it instead of rounding and do floating point calculations?

- QEyesPlugin: remove deprecated setMargin() call

TODO: check if syntax is correct and equivalent

Qt::AA_UseHighDpiPixmaps has no effect now

stefonarch · 2024-03-07T20:38:11Z

panel/lxqtpanel.cpp

+        anchors.setFlag(LayerShellQt::Window::AnchorRight);
+        mLayerWindow->setAnchors(anchors);
+
+        mLayerWindow->setKeyboardInteractivity(LayerShellQt::Window::KeyboardInteractivityNone);


This should be KeyboardInteractivityOnDemand otherwise typing in search and using arrow keys won't work in most compositors. See labwc/labwc#1594

Oh, and Ondemand fixed also those popup opening as normal windows in add-favorites dialog, directorymenu, mount and else!

Done. Thanks for the hint.
Here starting nested labwc with your startlxqtlabwc script it doesn't solve the issue.
FancyMenu does not receive keyboard input. Anyway it's more correct now

Just to be sure I've started labwc session directly from SDDM to double check.
I've also tried setting "Exclusive" keyboard focus.
Still not working.

You need latest labwc, they fixed it today. pcmanfm-qt --desktop had the same issue, no keyboard.

pcmanfm-qt --desktop had the same issue, no keyboard.

Yes, the keyboard focus problem of pcmanfm-qt's desktop was also fixed by a patch. LabWC's devs are very fast.

Set layer shell keyboard interactivity on-demand

stefonarch · 2024-03-11T08:02:09Z

@gfgit Could you implement this for "Configure panel" window?
lxqt/lxqt-config#984

With some help from @tsujan I did already stefonarch/lxqt-session@201d6ee

tsujan · 2024-03-11T12:29:36Z

@gfgit Could you implement this for "Configure panel" window?

I really think we need to avoid overusing layer-shell-qt.

gfgit · 2024-03-11T12:41:48Z

I really think we need to avoid overusing layer-shell-qt.

Hi, I was thinking the same thing. Isn't lxqt-config just a normal app?
lxqt-leave might be an exception in this, but on non-tiling compositors it should open at sceen center like any other window...

tsujan · 2024-03-11T13:00:18Z

Isn't lxqt-config just a normal app?

Yes.

lxqt-leave might be an exception in this

@stefonarch has already taken care of it and waits for my Qt6 PR for lxqt-session to be merged (which should be merged only with other Qt6 PRs for components that depend on liblxqt, including lxqt-panel).

but on non-tiling compositors it should open at sceen center like any other window...

Stacking Wayland compositors have their options for that — for centering (default in LabWC) or not — and, IMHO, we should respect those options.

stefonarch · 2024-03-11T13:10:14Z

It's ok if you don't use tiling WM like sway or hyprland where you need again window rules to make them float. I tested with the lxqt-leave and it behaves ok. We only need to force position IMO, not layer or keyboard to avoid those rules which are never 100% working.
Example Hyprland:

# LXQt Settings windows, policykit
windowrule = float,^(lxqt-.*)$
windowrule = float, ^(pavucontrol-qt)$

sway

# LXQt (config) windows
    for_window [app_id="^lxqt-.*$"] floating enable
    ```

tsujan · 2024-03-11T13:14:19Z

It's ok if you don't use tiling WM

Tiling WMs need to fix their UX problems themselves. It's not our job to do their work for them ;)

stefonarch · 2024-03-11T13:56:28Z

It's ok if you don't use tiling WM

Tiling WMs need to fix their UX problems themselves. It's not our job to do their work for them ;)

I know you dislike them ;)

My opinion is this: if we can provide a good out-of-the-box experience we should do it. We pretend also being modular and to work with any WM/compositor.

tsujan · 2024-03-11T14:57:11Z

We pretend also being modular

Being modular is one thing, adding codes to compensate for others' problems is another. The latter would make LXQt codes dirty and unmaintainable if we didn't avoid it.

stefonarch · 2024-03-12T06:30:38Z

Trying to build again on Neon stable it fails here: https://paste.debian.net/1310396/
After fixing this I get in plugin-taskbar/lxqttaskbarplugin.h line 62 "undefined inteface"

stefonarch · 2024-03-12T15:11:44Z

After fixing this I get in plugin-taskbar/lxqttaskbarplugin.h line 62 "undefined interface"

I see this happens if I compile directly this branch. If I compile first wip_qt6 branch it does compile.
So it looks there is something missing here.

stefonarch · 2024-03-15T17:10:36Z

I continue to consider not centering the panel config dialog a bug we should fix - in tiling WM at least it doesn't get covered by a left or right panel:

stefonarch · 2024-03-15T19:09:41Z

@gfgit Just learned that qmpanel has working taskbar support on wayland for wlroots-based compositors: https://github.com/jlindgren90/qmpanel/blob/master/panel/taskbar.cpp

gfgit · 2024-03-15T21:11:31Z

in tiling WM at least it doesn't get covered by a left or right panel

Isn't this supposed to just work™ with layer shell protocol on the panel which reserves screen space?

stefonarch · 2024-03-15T21:31:50Z

It should and it's somehow an exception, as issues with alignment (tooltips, fancymenu dialog) can be seen only on bottom and right panels. I first thought it was about right panels only.

gfgit · 2024-03-15T23:09:08Z

It should and it's somehow an exception, as issues with alignment (tooltips, fancymenu dialog) can be seen only on bottom and right panels. I first thought it was about right panels only.

I think it's worth filing a bug to affected tiling compositors and see if they can fix it.

stefonarch · 2024-03-16T06:35:16Z

I think it's worth filing a bug to affected tiling compositors and see if they can fix it.

Maybe I wasn't clear: this is an issue on stacking WMs, in tiling WM without window rules it's tiled as any other:

with windowrule = float,^(lxqt-.*)$ it is floating, with layershell code it would always be floating and centered on any WM:

I noticed that in kwin_wayland it is centered by default.

Consolatis · 2024-03-16T06:51:42Z

I continue to consider not centering the panel config dialog a bug we should fix - in tiling WM at least it doesn't get covered by a left or right panel:

What compositor is that? If the panel is correctly configured to use the exclusive zone (and updates it on window resize), the window should likely not overlap the panel area.

The protocol does not enforce that restriction though. It also says about the exclusive zone:

 A positive zone is the distance from the edge in surface-local
 coordinates to consider exclusive.

So that would mean if the panel is anchored to the top, right and bottom edges, the exclusive zone should be set to the panel width rather than height.

stefonarch · 2024-03-16T09:14:52Z

What compositor is that?

It's labwc. I made a test assuming that wayfire had the same issue, but it behaves like kwin, centering this panel config dialog without rules.
The exclusive zone works fine as in the other screenshots (Hyprland) but only if the panel width i set to 100% .

stefonarch · 2024-03-16T20:33:13Z

I didn't keep in mind that I was on a branch (for testing exit session) which didn't have the panel focus fix and maybe else. So there is no issue with exclusive zone on left/right panels in labwc git:

stefonarch · 2024-03-16T21:51:49Z

autostart/lxqt-panel_wayland.desktop

+TryExec=lxqt-panel
+
+# NOTE: KWin wants absolute path here, make sure it's correct
+Exec=/usr/local/bin/lxqt-panel


This is the reason why only pager worked on arch.
This file has to be configured by cmake to match the installation path. Changing it to /usr/bin kwin_wayland session is fully functional here now :)
Could have seen it earlier.

tsujan · 2024-03-17T13:14:47Z

probably for this feature of the floating panel in plasma

Do they really call it a feature or are you joking? The second problem of Plasma 6 that attracted my attention yesterday was its panel (under X11 — wasn't brave enough to log into its Wayland session).

stefonarch · 2024-03-17T13:54:52Z

Do they really call it a feature or are you joking

I put it first between " " but removed them as I'm trying to be polite;)
I logged into plasma and disabled the floating panel but this space didn't disappear, it's in Neon too I saw. Maybe open a bug report is necessary.

stefonarch · 2024-03-20T06:11:50Z

Could this solve eventually the alignment issues in bottom/right panels?

git://code.qt.io/qt/qtwayland.git:

QRect placementAnchor = m_window->window()->property("_q_waylandPopupAnchorRect").toRect();
   if (!placementAnchor.isValid()) {
       placementAnchor = QRect(m_window->geometry().topLeft() - parent->geometry().topLeft(), QSize(1,1));
   }
...
   positioner->set_anchor_rect(placementAnchor.x(),
                               placementAnchor.y(),
                               placementAnchor.width(),
                               placementAnchor.height());»
                               ```

stefonarch · 2024-03-20T22:06:01Z

Just another maybe useful snippet for alignment:
https://github.com/jlindgren90/qmpanel/pull/8/files

stefonarch · 2024-03-26T07:14:25Z

Not sure what has changed - it was some time I didn't use kwin_wayland session, but can't get the taskbar to work now anymore.

As it looks that the review of taskbar-refactor will take much time I think we should have a PR only for the panel wayland code for now.

gfgit · 2024-03-26T11:46:44Z

Replaced by #2043

CMake: FindXCB components are upper case

5dc5d82

Fixes CMake error

gfgit mentioned this pull request Feb 24, 2024

Wayland support lxqt/lxqt#10

Closed

gfgit added 12 commits February 28, 2024 18:57

CMake: update dependencies for Qt6

07f702a

CMake: link to dbusmenu-lxqt instead of dbusmenu-qt6

b4fe335

StatusNotifierButton: switch to dbusmenu-lxqt

Replace qAsConst() with std::as_const

96a6dc6

Replace QPair with std::pair

bfcf78a

Replace QLatin1Literal with QLatin1String

61893fb

QEvent: port pos() to position() and globalPos() to globalPosition()

fb5c5c8

- Now returns floating point QPointF, should we keep it instead of rounding and do floating point calculations?

Fix QWidget::enterEvent(QEnterEvent*) signature

d1c1ce8

QLayou::setContentsMargin() instead of setMargin()

190280c

- QEyesPlugin: remove deprecated setMargin() call

QuickLaunchButton: fix ambiguous list initializer

b8b33c6

Port QRegExp with QRegularExpression TODO

79c4a48

TODO: check if syntax is correct and equivalent

QLocale territory() instead of country()

cb2d7cb

Qt6 always enables High-DPI Pixmaps

a955bb6

Qt::AA_UseHighDpiPixmaps has no effect now

stefonarch reviewed Mar 7, 2024

View reviewed changes

LXQtPanel: set LayerShellQt KeyboardInteractivityOnDemand

794648c

Set layer shell keyboard interactivity on-demand

stefonarch reviewed Mar 16, 2024

View reviewed changes

gfgit mentioned this pull request Mar 26, 2024

Wayland taskbar support v2 #2043

Open

gfgit closed this Mar 26, 2024

Wayland taskbar support #2031

Wayland taskbar support #2031

Conversation

gfgit commented Feb 24, 2024

stefonarch commented Feb 24, 2024 • edited Loading

stefonarch commented Feb 24, 2024 • edited Loading

gfgit commented Feb 24, 2024

stefonarch commented Feb 24, 2024 • edited Loading

gfgit commented Feb 24, 2024

stefonarch commented Feb 24, 2024

stefonarch commented Feb 24, 2024 • edited Loading

stefonarch commented Feb 24, 2024 • edited Loading

stefonarch commented Feb 24, 2024 • edited Loading

gfgit commented Feb 25, 2024 • edited Loading

gfgit commented Feb 25, 2024

stefonarch commented Feb 25, 2024

stefonarch commented Feb 25, 2024

gfgit commented Feb 26, 2024 • edited Loading

stefonarch commented Feb 26, 2024

stefonarch commented Feb 26, 2024

stefonarch Mar 7, 2024

Choose a reason for hiding this comment

stefonarch Mar 7, 2024

Choose a reason for hiding this comment

gfgit Mar 9, 2024

Choose a reason for hiding this comment

gfgit Mar 9, 2024

Choose a reason for hiding this comment

stefonarch Mar 9, 2024 • edited Loading

Choose a reason for hiding this comment

tsujan Mar 9, 2024

Choose a reason for hiding this comment

stefonarch commented Mar 11, 2024

tsujan commented Mar 11, 2024

gfgit commented Mar 11, 2024

tsujan commented Mar 11, 2024

stefonarch commented Mar 11, 2024 • edited Loading

tsujan commented Mar 11, 2024

stefonarch commented Mar 11, 2024

tsujan commented Mar 11, 2024

stefonarch commented Mar 12, 2024 • edited Loading

stefonarch commented Mar 12, 2024

stefonarch commented Mar 15, 2024 • edited Loading

stefonarch commented Mar 15, 2024

gfgit commented Mar 15, 2024

stefonarch commented Mar 15, 2024

gfgit commented Mar 15, 2024

stefonarch commented Mar 16, 2024 • edited Loading

Consolatis commented Mar 16, 2024 • edited Loading

stefonarch commented Mar 16, 2024

stefonarch commented Mar 16, 2024

stefonarch Mar 16, 2024

Choose a reason for hiding this comment

tsujan commented Mar 17, 2024

stefonarch commented Mar 17, 2024 • edited Loading

stefonarch commented Mar 20, 2024

stefonarch commented Mar 20, 2024

stefonarch commented Mar 26, 2024

gfgit commented Mar 26, 2024

stefonarch commented Feb 24, 2024 •

edited

Loading

stefonarch commented Feb 24, 2024 •

edited

Loading

stefonarch commented Feb 24, 2024 •

edited

Loading

stefonarch commented Feb 24, 2024 •

edited

Loading

stefonarch commented Feb 24, 2024 •

edited

Loading

stefonarch commented Feb 24, 2024 •

edited

Loading

gfgit commented Feb 25, 2024 •

edited

Loading

gfgit commented Feb 26, 2024 •

edited

Loading

stefonarch Mar 9, 2024 •

edited

Loading

stefonarch commented Mar 11, 2024 •

edited

Loading

stefonarch commented Mar 12, 2024 •

edited

Loading

stefonarch commented Mar 15, 2024 •

edited

Loading

stefonarch commented Mar 16, 2024 •

edited

Loading

Consolatis commented Mar 16, 2024 •

edited

Loading

stefonarch commented Mar 17, 2024 •

edited

Loading