Fix background color with GTK3 #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also noticed this issue, though it only happens when you have a single tab open. Edit: I can confirm that this indeed fixes the color of that background. Btw another difference (not caused by your PR) I noticed in the GTK 3 version is that it doesn't have lines around the toolbar like the GTK 2 version has. |
LStranger
reviewed
Mar 16, 2021
| @@ -1878,6 +1878,16 @@ exo_icon_view_expose_event (GtkWidget *widget, | |||
|
|
|||
| if (!gtk_cairo_should_draw_window (cr, priv->bin_window)) | |||
| return FALSE; | |||
|
|
|||
| /* draw a background according to the css theme */ | |||
| style = gtk_widget_get_style_context (widget); | |||
There was a problem hiding this comment.
I suppose it should be not retrieved again at line 1993 with this addition, right?
There was a problem hiding this comment.
Correct, I just tried and it works the same. PR updated
LStranger
reviewed
Mar 16, 2021
| #if GTK_CHECK_VERSION(3, 0, 0) | ||
| style = gtk_widget_get_style_context (widget); | ||
| #else | ||
| #if !GTK_CHECK_VERSION(3, 0, 0) |
There was a problem hiding this comment.
This line should be moved above if to not leave it alone.
There was a problem hiding this comment.
You're right. I should look twice before committing. Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried building for gtk3, and the background color was wrong (it was the same as the toolbars - see attached picture, left side). This is how I fixed it (result on right side). I can make changes if required for merging.