Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed tests #231

Merged
merged 24 commits into from
Jan 20, 2025
Merged

Distributed tests #231

merged 24 commits into from
Jan 20, 2025

Conversation

kozlov721
Copy link
Collaborator

@kozlov721 kozlov721 commented Jan 17, 2025

  • All the tests are now fully independent and sandboxed:
    • More robust environment
    • Possible to run tests in parallel using pytest-xdist plugin
      • Roughly 3 times faster execution of GH workflows
    • conftest.py updated with some useful fixtures for easier sandboxing of tests:
      • tempdir - an empty temporary directory
      • dataset_name - a unique name that can be used for instantiation of LuxonisDataset
      • randint - a random integer between 0 and 100,000
      • python_version - the version of Python running the tests
      • platform_name - the name of the platform running the tests
  • Cleaned up tests for LuxonisFileSystem and fixed some bugs
  • Fixed the s3 error (incompatible new version of aiobotocore)
  • Updated CONTRIBUTING.md

@kozlov721 kozlov721 requested a review from a team as a code owner January 17, 2025 20:01
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team January 17, 2025 20:01
@github-actions github-actions bot added tests Adding or changing tests utils Changes affecting luxonis_ml.utils subpackage DevOps Changes related to DevOps labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 99.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (ded9a08) to head (63a2c7b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/conftest.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   95.85%   95.78%   -0.08%     
==========================================
  Files          89       89              
  Lines        4758     4771      +13     
==========================================
+ Hits         4561     4570       +9     
- Misses        197      201       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozlov721 kozlov721 merged commit 27657d6 into main Jan 20, 2025
12 checks passed
@kozlov721 kozlov721 deleted the tests/distributed branch January 20, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Changes related to DevOps tests Adding or changing tests utils Changes affecting luxonis_ml.utils subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants