Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions Wokflow for Windows #415

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

leso-kn
Copy link
Contributor

@leso-kn leso-kn commented Oct 27, 2023

This PR closes #414 and provides the two changes listed below.

Note that most of the required work has taken place in relation to gh-actions-lua and has been submitted to the upstream repository: !35, !37, !38 and gh-actions-luarocks!14.

In the meantime this PR changes the sources of leafo/gh-actions-lua@v9 and leafo/gh-actions-luarocks@v4 to leso-kn/gh-actions-lua@v11-staging and hishamhm/gh-actions-luarocks@master in build.yml until the related PRs are merged upstream.

Contents

  • Refactor (core): Replace the check for SO_BINDTODEVICE support with a platform-independent version
  • CI: Enable windows build (windows-2022)

Showcase
Successful pipeline log with Windows build enabled.

@leso-kn
Copy link
Contributor Author

leso-kn commented Oct 27, 2023

Please note, that all checks have passed (see here).
There seems to be a display bug, for me there's a message saying "Some checks haven't completed".

@alerque
Copy link
Member

alerque commented Oct 27, 2023

Fantastic. Lets pop open an issue to track resetting the GH Actions used here to the canonical ones as soon as they have supported releases (so noting what PR or whatever it is we have to hold out for).

The checks not completed messages is because I have some checks marked as required, but GHA only shows actions that have run on the target branch as options. This PR changes the CI matrix and the jobs that ran here in the PR are not the same ones as I have marked it to expect. I can merge with admin privs, then after these jobs run on master I'll be able to update the required CI jobs list for future PRs.

@leso-kn
Copy link
Contributor Author

leso-kn commented Oct 30, 2023

@alerque I've opened a respective issue here: #416

@alerque alerque merged commit 0f37af6 into lunarmodules:master Oct 30, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Windows build broken because SO_BINDTODEVICE is not defined
2 participants