Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcpkg installation instructions #304

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PhoebeHui
Copy link

LuaSocket is available as a port in VCPKG , documenting the install process here will help users get started by providing a single set of commands to build LuaSocket, ready to be included in their projects.

VCPKG is a C++ library manager that simplifies installation for LuaSocket and other project dependencies, we also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64, UWP, ARM) to keep a wide coverage for users.

I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library.

@ewestbrook
Copy link
Contributor

I vote no. There are already many ways to build and install LuaSocket. Let's improve those, if needed, rather than advertise another.

@avently
Copy link

avently commented Aug 12, 2020

@PhoebeHui hello. Looks like there is no way to build luasocket with lua 5.1 using your package manager, am I right? There is only the latest version of Lua available. How to work around this issue?

@PhoebeHui
Copy link
Author

@avently, if you want to use lua 5.1, you can follow below steps:

  1. Open ./ports/lua/portfile.cmake, update the URLS and FILENAME with lua 5.1
  2. ./vcpkg install lua, it would fail since the hash is not correct, you can copy the 'Actual Hash', and replace the hash value.
  3. Commnent out PATCHES vs2015-impl-c99.patch since it's only for latest revision.
  4. Check the src and headers in ports/lua/CMakeLists.txt file, remove these file doesn't in lua 5.1, and add the missing one.
  5. /vcpkg install lua

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trim this down to a minimal mention of the package availability, not a tutorial on how to use vcpkg itself.

doc/installation.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants