Unlock line link for modified files & introduce smarter commit picking #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lunakoly
commented
Sep 28, 2024
•
lunakoly
commented
In my experience, it's quite easy to quickly open it in the browser and fix the line manually compared to looking for another way to share the link.
After this change there are now 3 actions: - generating a link to the currently checked out commit - generating a link to the latest commit from the remote's default branch - generating a link to some parent commit that is definitely available at the remote ...with the last one becoming the default assigned to `Cmd`+`Shift`+`L`. The main use cases are generating a link to whatever I see in my IDE (so, close commits tend to also be acceptable since the code hasn't changed much) or showing something that is currently in the latest master. Also, I expect there to be not that many users relying on the plugin generating a link to exactly the current commit in scenarios when it has not been pushed, thought I don't really have any statistics. I assume no one has tried automating anything by calling the action or the default shortcut.
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.