Draft: CMake-ify the build #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- installs only the executable and some sound files; this is enough to convince lumina-desktop to start, not enough for it to be useful. The pkg-plist shows many more files, so those need to be chased down.
The icon-themes are special because they live outside the source-tree for lumina-core; introduce a function for installing themes to simplify upcoming material-design themes.
- add an extension to the install_theme function to help with placing SVGs in suitable subdirectories
|
I really appreciate your work on this. |
|
Merging this into a branch here in this repo so if I or other get time we can base off of your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch, not-finished-yet, that ports the build of
core/and attendant bits from qmake, to CMake. There is one source-code change. There is also one new build-time dependency: KDE's extra-cmake-modules, which provide all kinds of useful CMake modules for Qt-based applications (and in particular, a FindXCB module).Filing the PR in draft state so it can be seen to be "in-progress".