-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delayed requests #125
base: master
Are you sure you want to change the base?
Delayed requests #125
Conversation
+1 to this - nice work @pcantrell , I've also been wishing for this. |
|
537ee6d
to
e978c8a
Compare
Rebased for easy peasy merging fun. FWIW, this code has been tested in the wild — in use on Siesta for the past 2 months, and working great. Here’s an example of how it plays out in practice: https://github.com/bustoutsolutions/siesta/blob/master/Tests/ResourceRequestsSpec.swift#L109-L116 |
+1 to this too! I've tested it and it works smoothly! |
+1 Would be excellent if this gets accepted and merged @luisobo .
|
This seems reasonable, however in the meantime OS X and tvOS targets have been added to the master. If you rebase we should be able to make the merge easy and I can pull it in. Seems simple and makes sense. |
80699b8
to
c7ef374
Compare
Rebased against latest master. Specs pass. In successful use now for |
A possible approach to #123.
This PR adds
delay()
andgo()
methods to the response DSL. This allows clients to do:This is an incomplete implementation:
LSHTTPStubURLProtocol
, and@luisobo, let me know if you have thoughts about this approach. If so, I’ll update the PR with the full implementation.