Redesign command line interface #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns "modify" into an alias and "edit" into the main command name for editing contacts.
Both commands are used to edit a file corresponding to a single contact. The functionality of both commands is now subsumed under the "edit" subcommand. Editing the source file is possible with the new option "--format=vcard".
|
There is one problem with the unification of the different ls subcommands. At least the phone subcommand tries to match the search terms against the phone numbers and not the rest of the card. This makes sense but is harder to unify with the other listing like subcommands. I think I will try to rework the matching of cards first to have a better documented api for matching cards in specific ways. This could also help with implementing something like #131. In conclusion I will leave this PR as is and only add more code in a new PR. |
|
@scheibler as this feels like a fundamental decision to me and is also user facing I would like to have a short ok/no from you before I proceed. |
|
@scheibler ping? |
|
@scheibler ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the corresponding PR for #179. Until now the unification of show-export and edit-source is done. The unification of the different ls versions is underway.
I am happy about any feedback.