Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move temp folder instead of renaming #83

Closed
wants to merge 2 commits into from
Closed

fix: Move temp folder instead of renaming #83

wants to merge 2 commits into from

Commits on Sep 25, 2023

  1. fix: handle linkDir existence 

    As nodeModulesDirForPackageInner is asynchronous and contains
several `await` calls, the file can be created after the first
check for existence.

The error thrown by `Deno.rename` is not an instance of
`Deno.errors.AlreadyExists`, but `move` does work as expected.
Tested on macOS (OS error 66) and linux (OS error 39)
    @mxdvl
    mxdvl committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    181252a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. refactor: keep setting the cache 

    ensure behaviour is kept as-is,
to make review process easier
    @mxdvl
    mxdvl committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    e430489 View commit details
    Browse the repository at this point in the history