Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial_service.readBytes in wait_for_ack #497

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

MichaelDu9226
Copy link

Maybe this is a bug:)

Thanks for your great work.

I am an engineer from Rotrics, a company that creates desktop robotic arms, this is our official website: https://www.rotrics.com/
We have a TouchScreen accessory based on ESP32/ESP-ADF/LVGL, and I am trying to port ESP-3D to it. I am trying these features: send gcode file from direct sdcard & 3.5TFT LVGL.

Thanks again for your great work. I hope I can contribute more to this project in the future.

@luc-github
Copy link
Owner

Hi thank you for your Feedback, the GCODE host code actually need to be rewritten because it is not working as expected yet, and yes may surely have bugs

here latest status #243 (comment)

I am planning to work on it soon (within 2 weeks) because I will also implement the Macro support in webUI 3.0 in coming weeks

@luc-github
Copy link
Owner

@MichaelDu9226
Copy link
Author

@luc-github Yes. This is our touchscreen. I have completed&tested the SD card host send gcode based on ESP-3D 3.0.

But this touch screen was previously based on ESP-ADF&LVGL, not esp-arduino-core. So, we are considering how to port ESP32-3D in the future.

@luc-github
Copy link
Owner

wow!! host gcode works as expected? happy to read that
it was in my plan to do such project too once 3.0 will be released
as 3.0 already support lvgl
my proto board use ili9341 with xtp2046
my main concern was size of ui pictures in flash

what is your screen specs ? I only see 8MB flash
also 8MB psram? last time I checked PSRAM speed a lot but also bring some instability
also in arduino only 4MB were usable.

you mean you plan to port esp3d to idf ? or to port your code to arduino ?

@luc-github luc-github merged commit 0615c3e into luc-github:3.0 Sep 2, 2020
@MichaelDu9226
Copy link
Author

Yes. Host gcode works as expected. I haven't added Marlin's line number and checksum yet.

Because our touchscreen supports voice control, such as "Draw me an apple". This is based on ESP-ADF(Audio Development Framework), so we plan port esp3d to ESP-IDF. But it has not been finalized.

@MichaelDu9226
Copy link
Author

MichaelDu9226 commented Sep 2, 2020

The specs is 8MB flash & 8MB psram, The audio lvgl and network both need more memory.
I think it is also very suitable for ESP3D.

@luc-github
Copy link
Owner

@all-contributors please add @MichaelDu9226 for code improvement

@allcontributors
Copy link
Contributor

@luc-github

I've put up a pull request to add @MichaelDu9226! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants