-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default log level to info #14
Conversation
WalkthroughThe changes in this pull request involve modifications to the logging configuration within the Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant Logger
participant FileAppender
App->>Logger: Initialize logging
Logger->>Logger: Set log level to INFO
Logger->>FileAppender: Configure file logging
FileAppender-->>Logger: Return guard
Logger->>App: Logging initialized
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- crates/cmd/src/main.rs (2 hunks)
🧰 Additional context used
🔇 Additional comments (3)
crates/cmd/src/main.rs (3)
4-4
: LGTM: Appropriate import addedThe import of
LevelFilter
is correctly added and is necessary for the changes made to the logging configuration.
19-20
: LGTM: Console logging configuration updated correctlyThe changes to the console logging configuration are well-implemented:
- The
filter_layer
now includesLevelFilter::INFO
, which aligns with the PR objective.- The implementation is consistent with Rust logging best practices.
- The added empty line improves code readability.
These changes effectively set the default log level to INFO for console logging.
27-27
: LGTM: File logging configuration updated consistentlyThe changes to the file logging configuration are well-implemented and consistent with the console logging changes:
- The
filter_layer
now includesLevelFilter::INFO
, which aligns with the PR objective.- The implementation ensures that both console and file logging use the same log level filter.
This change effectively sets the default log level to INFO for file logging, maintaining consistency across logging methods.
323509d
to
5664951
Compare
Summary by CodeRabbit
INFO
level or higher, improving the clarity of log outputs.