New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review the use of `String` and switch to `&str` when possible #22

Merged

shumbo merged 2 commits into shumbo/available-locations from shumbo/http-str

Oct 7, 2023

Member

shumbo commented Oct 7, 2023

For better performance.

Location names are always &'static str and we do not need to turn them into Strings
Hostname for the HTTP transport can also be &str because they are fixed and we don't mutate.

shumbo added 2 commits

October 6, 2023 18:08


          review the use of String and switch to &str when possible

aafdc00


          get rid of more String

4840a96

shumbo merged commit 897104c into shumbo/available-locations

3 checks passed

shumbo deleted the shumbo/http-str branch

October 7, 2023 01:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet