Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename HList to LocationSet #18

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Rename HList to LocationSet #18

merged 1 commit into from
Oct 3, 2023

Conversation

shumbo
Copy link
Member

@shumbo shumbo commented Oct 3, 2023

SSIA

@shumbo shumbo marked this pull request as ready for review October 3, 2023 07:13
@shumbo shumbo requested a review from ihaveint October 3, 2023 07:14
ihaveint
ihaveint reviewed Oct 3, 2023
View reviewed changes
chorus_lib/src/core.rs
Copy link
Collaborator

@ihaveint ihaveint Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the docs are hidden for this, but you might want to rename them from HList to LocationSet too (lines 105, 114, and 118)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, actually, now that I think more about it, it might make sense to keep it that way since HList is a reminder that it is a heterogeneous list internally.

@shumbo shumbo merged commit 8f8f81a into shumbo/available-locations Oct 3, 2023
3 checks passed
@shumbo shumbo deleted the call-hlist-location-set branch October 6, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihaveint ihaveint ihaveint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shumbo @ihaveint