-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location set tweaks #16
Merged
shumbo
merged 14 commits into
shumbo/available-locations
from
available-locations-tweaks
Oct 2, 2023
Merged
Location set tweaks #16
shumbo
merged 14 commits into
shumbo/available-locations
from
available-locations-tweaks
Oct 2, 2023
+323
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihaveint
reviewed
Oct 2, 2023
ihaveint
reviewed
Oct 2, 2023
ihaveint
reviewed
Oct 2, 2023
ihaveint
reviewed
Oct 2, 2023
ihaveint
reviewed
Oct 2, 2023
ihaveint
reviewed
Oct 2, 2023
ihaveint
reviewed
Oct 2, 2023
ihaveint
requested changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. A few places need edits, but a couple of them is up to you to decide.
ihaveint
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be all good now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several adjustments to the ongoing location set project.
Macros
macro_export
exports the macro under the root crate. In our case,LocationSet!
was qualified aschorus_lib::LocationSet
. However, theLocationSet
macro should be part of thecore
module. There is no way to achieve this in the current Rust ecosystem, but the common workaround is to give the macro a different internal name and re-export it from the module. I applied this workaround toLocationSet
.Separate builder structs
This PR separates the builder struct for
LocalTransportChannel
andTransportConfig
.#14 (comment)
As discussed, if we apply the builder pattern on
LocalTransportChannel
itself, we have to construct new hashmaps again and again. While this is not a big problem for now, I want to explore other design options.One option is to create a separate builder struct, accumulate information on that struct, and call
build
that produces the desired data type at the end. This allows us to have separate code for accumulating information vs. instantiating the final struct.Because it can be confusing to mix the two styles (calling methods directly on the struct / using the separate builder struct), I changed both
LocalTransportChannel
andTransportConfig
to the latter style.