-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix literal
flag not being recognized from config file
#935
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Akmadan23 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
83f7928
to
e6cb90e
Compare
Sorry @zwpaper, I noticed you have been active in merging PRs recently, could you please take a look at this? It's a very simple fix to a real problem. |
hi @Akmadan23 , sorry for the late reply, I have started the test and will take a deeper look into it tomorrow, it looks good at a glance 😃 |
hi @Akmadan23, I have checked your fix, and it works like a charm! thanks for the contribution! please rebase your code onto master, so that CI can pass, and then we should be good to go |
e6cb90e
to
eac2ea9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #935 +/- ##
==========================================
- Coverage 85.76% 85.75% -0.01%
==========================================
Files 51 51
Lines 5001 4998 -3
==========================================
- Hits 4289 4286 -3
Misses 712 712 ☔ View full report in Codecov by Sentry. |
eac2ea9
to
0231b9b
Compare
Now everything should be good to go |
thanks for the contribution! |
The
literal
option was not correctly recognized from config file due toLiteral::from_cli
returningSome(Literal(false))
instead ofNone
, soLiteral::from_config
would never have been executed.TODO
cargo fmt