Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of unused or outdated files #363

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Cleanup of unused or outdated files #363

wants to merge 9 commits into from

Conversation

HomesGH
Copy link
Contributor

@HomesGH HomesGH commented Dec 19, 2024

Description

There are a lot of outdated or unused files which haven't been touched in ages. Those are probably not in use anymore or not even compilable. Therefore, we should delete them.

The following is deleted:

  • Empty files
  • validation folder (which was used by Jenkins in the past) since it is not used anymore. The input for the CI is now based on the examples.
  • Unused files in the examples folder: argon.sh (just runs the argon example) and comparison.xml (which is a random config xml)
  • Tools to convert VERY old mader files to ls1
  • Tool to accumulate values of the ResultWriter since this is probably not used anymore (use Python instead)
  • standalone generators since this functionality is now implemented in ls1 using the ObjectGenerator in the xml config directly --> Remove standalone-generators #364
  • GUI-Tool for generators since (I think) nobody uses them and they are probably outdated
  • grideval since it is not documented and, therefore, probably not used anymore

Moved files:

  • Script to check several build options moved to checks folder

Resolved Issues

How Has This Been Tested?

I had a look at the git history and tried to decide if the file/folder is still in use or will never be in the future.
Maybe I have deleted too much, so feel free to give some feedback or suggest further files.

@HomesGH HomesGH added the clean-up related to the clean-up of the code and tech dept label Dec 19, 2024
@cniethammer cniethammer self-requested a review December 19, 2024 22:33
Copy link
Contributor

@cniethammer cniethammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to go over this - that's a really good bunch of cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up related to the clean-up of the code and tech dept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants