Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improvement of Logger #308

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Fix and improvement of Logger #308

merged 4 commits into from
Jul 16, 2024

Conversation

HomesGH
Copy link
Contributor

@HomesGH HomesGH commented May 22, 2024

Description

Not everything has been set up correctly in the Logger class. Therefore, the type of output (e.g. INFO, WARNING) was missing, if the --logfile option of ls1 was used.

To improve the readibility and to distinguish between bools and numbers, the output of booleans was set to be true/false instead of 1/0.

The present PR is related to the split-up of PR #255.

How Has This Been Tested?

A simulation with the logfile option was run and it was checked that the resulting file includes the type of output (first column).

@HomesGH HomesGH added bug Something isn't working enhancement New feature or request labels May 22, 2024
@HomesGH HomesGH requested a review from cniethammer May 22, 2024 12:37
@HomesGH HomesGH requested review from FG-TUM and amartyads July 15, 2024 17:26
@HomesGH HomesGH merged commit 0d99496 into master Jul 16, 2024
52 checks passed
@HomesGH HomesGH deleted the fixLogger branch July 16, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants