Fix type of _adaptive and _periodic parameters in FMM to bool #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The adaptive parameter was inconsistently used as integer and bool throughout the code. Signed-off-by: Christoph Niethammer <[email protected]>
2 tasks
HomesGH
previously approved these changes
Feb 13, 2024
|
While you are at it: The xml parameter right below |
The periodic parameter was used as bool throughout the code. Signed-off-by: Christoph Niethammer <[email protected]>
|
Sure! I updatet the PR to include the periodic parameter as well. Concerning the also |
cniethammer
changed the title
|
@HomesGH can you review this so it can be merged in a timely manner - if everything looks good - and I can come up with the next PR that otherwise would conflict? THX |
HomesGH
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adaptive parameter was inconsistently used as integer and bool throughout the code.
This was discovered during work on #286