Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixing rules in input files for the DropletCoalescence example #278

Merged

Conversation

cniethammer
Copy link
Contributor

@cniethammer cniethammer commented Nov 6, 2023

Description

Fix mixing rules for the DropletCoalescence example.

The XML path for the mixing rules was incorrect in the configuration files of this example and therefore the mixing rules were not applied correctly.

Related Pull Requests

Resolved Issues

(None)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Running DropletCoalescing example and verifying that the initial output shows the correct Mixing rules:

...
Found 1 mixing rules.
...
Mixing rule type: LB
...
Mixing coefficients: (eta, xi) = (1, 1)

@cniethammer cniethammer requested a review from HomesGH November 6, 2023 13:02
@cniethammer cniethammer added the bug Something isn't working label Nov 6, 2023
@cniethammer cniethammer self-assigned this Nov 6, 2023
@cniethammer cniethammer merged commit 71181e3 into ls1mardyn:master Nov 8, 2023
52 checks passed
@cniethammer cniethammer deleted the bugfix-dropletcoalescence-example branch November 8, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants