-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ainur Harfi Alfaraby #24
Open
harfialpharaby
wants to merge
7
commits into
loyal-fox-2019:master
Choose a base branch
from
harfialpharaby:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- readme = add docs for login and register api - app.js = initial commit on expressjs - controllers/user.js = add usercontroller to handle login and register - middlewares/errorhandler.js = add errorhandler for any errors - models/user = add user model using mongoose - routes/index.js = add route to all pages - routes/user.js = add user route to access login and register
1. helpers/hashPassword.js = separated coding file 2. models/user.js = import hashPassword to hash registered password
…obal to handle ignore files in client Changes to be committed: new file: .gitignore new file: client/index.html new file: client/package-lock.json new file: client/package.json new file: client/src/App.vue new file: client/src/LoginPage.vue new file: client/src/RegisterPage.vue new file: client/src/UserPage.vue new file: client/src/components/GLoginButton.vue new file: client/src/components/GLogoutButton.vue new file: client/src/components/LoginForm.vue new file: client/src/main.js new file: client/src/mixins/googleMixin.js deleted: server/.gitignore modified: server/controllers/user.js modified: server/middlewares/errorHandler.js modified: server/models/user.js modified: server/package-lock.json modified: server/package.json modified: server/routes/user.js
documentation for article and tags done need to develop image upload feature to gcs Changes to be committed: modified: README.md new file: server/controllers/article.js new file: server/helpers/gcs-upload.js new file: server/middlewares/authentication.js new file: server/middlewares/authorization.js new file: server/models/article.js modified: server/package-lock.json modified: server/package.json new file: server/routes/article.js modified: server/routes/index.js
- fixing bugs on google sign-in components: modified: client/package-lock.json modified: client/package.json modified: client/src/UserPage.vue modified: client/src/components/GLogoutButton.vue modified: client/src/main.js modified: client/src/mixins/googleMixin.js - add article feature init: modified: server/controllers/article.js - add upload image feature for server side: deleted: server/helpers/gcs-upload.js new file: server/middlewares/gcsUpload.js new file: server/minivipi-8661fde99b6e.json modified: server/package-lock.json modified: server/package.json modified: server/routes/article.js
Changes to be committed: - updated readme, adding search by tagname and by title route modified: README.md - add create, read, update, delete feature on user page for article modified: client/src/UserPage.vue - add create and edit feature on post form new file: client/src/components/postForm.vue - add search by tag and title on article controller modified: server/controllers/article.js - fixing bugs when id on oauth and manual login are different modified: server/controllers/user.js modified: server/middlewares/authentication.js - adding some routes to handle search by tag and title of articles modified: server/routes/article.js
…rm/API project valued-amp-262711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment keys and values :
CLIENT_ID=546712715494-5hsnhes54gf2n4tll6dhbrvpvc9bk9qq.apps.googleusercontent.com
CLIENT_SECRET=dk_wCtQ85GKyBQuK1x_ZFwZz
KEYFILE=/home/harfi/phase2/portfolio/mini-wp/server/minivipi-8661fde99b6e.json
BUCKET_NAME=minivipi-img.harfialfaraby.com
MONGO_PASSWORD=admin