Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit button #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add exit button #318

wants to merge 1 commit into from

Conversation

SiliconValet
Copy link

#317

Adds an exit button with configuration to enable.

By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

Copy link
Owner

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very specific, and not really useful outside of your case. Maybe this should be an external plugin instead, and what we should have in the code is something like WBO_EXTERNAL_TOOLS that you would set to a value like ["http://example.com/yourtool.js"] ?

@SiliconValet
Copy link
Author

I didn't see a way to easily conditionally inject the tool js without resorting to a build process - If you've got a rough direction I can see if I can find time to whip it up.

@SiliconValet
Copy link
Author

Note that the exit button only shows up if the env var or config is set, invisible and missing by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants