Accept iterators with a non-void value_type #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
has_const_iterator
to additionally checkstd::iterator_traits
to exist andreturn_type
to be non-void
.This catches additional cases and is compatible with the iterator rules up to C++20.
Motivation for this change is the incompatibility with the new iterator interface of Eigen3, which sets
const_iterator = void
for non-vector types. This breaksprettyprint
.