-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace traverse with neotraverse #2285
chore: replace traverse with neotraverse #2285
Conversation
611a549
to
9f855cf
Compare
@digiz3d, thanks for the PR. And thanks for including the blog post, it's an interesting read :) |
9f855cf
to
dccccf4
Compare
Glad you found it interesting! done Unrelated, but on my current computer (mac M1) tests do not seem to pass, even on master. It looks like it is expecting english but receives french (probably my locale... somewhere?): edit: all good ✅ works with |
Pull Request Test Coverage Report for Build 10938709817Details
💛 - Coveralls |
Hi @digiz3d, thanks for the pull request! Just need to fix the merge conflict - Could you regenerate the lockfile with |
Signed-off-by: Léandre Daumont <[email protected]>
dccccf4
to
07d37fc
Compare
I've rebased the PR, lockfile should be up to date now 👍 |
Thanks, it's been merged 🎉 |
NGL I made this PR just to try it out. Hope it helps
This replaces
traverse
dependency, which is bloated with lots of useless dependencies, especially since the 0.6.9 version.Only to support node 0.4 that nobody uses anymore.
You can find many information about it on Twitter/X. Here is an article from the replacement library author here https://puruvj.dev/blog/forking-and-fixing-traverse
Checklist
npm test
passes on your machine