Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable Node.js v17 testing #1906

Merged
merged 1 commit into from
Nov 24, 2021
Merged

ci: enable Node.js v17 testing #1906

merged 1 commit into from
Nov 24, 2021

Conversation

achrinza
Copy link
Member

Signed-off-by: Rifa Achrinza [email protected]

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@achrinza achrinza force-pushed the ci/node-17 branch 2 times, most recently from aba86ca to 85b450a Compare November 20, 2021 10:54
@coveralls
Copy link

coveralls commented Nov 20, 2021

Pull Request Test Coverage Report for Build 1486376487

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.754%

Totals Coverage Status
Change from base Build 1261591086: 0.0%
Covered Lines: 7159
Relevant Lines: 8149

💛 - Coveralls

@achrinza achrinza force-pushed the ci/node-17 branch 3 times, most recently from 52e9c53 to a4aa7ab Compare November 21, 2021 03:19
@achrinza achrinza force-pushed the ci/node-17 branch 3 times, most recently from aacfeef to 2836c9d Compare November 21, 2021 04:44
@achrinza achrinza marked this pull request as ready for review November 21, 2021 04:53
@achrinza achrinza requested a review from dhmlau as a code owner November 21, 2021 04:53
@achrinza
Copy link
Member Author

Node.js v17 on ppc64le is failing due to some network issue. Wasn't able to figure out what's the issue, but I've opened loopbackio/cicd#3 to investigate further. This should not block merging this PR as the rest of the test matrix passed.

Signed-off-by: Rifa Achrinza <[email protected]>
@achrinza achrinza merged commit fe82f6a into master Nov 24, 2021
@achrinza achrinza deleted the ci/node-17 branch November 24, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants