Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit URL fix #109

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Exit URL fix #109

merged 6 commits into from
Nov 6, 2024

Conversation

okaycj
Copy link
Collaborator

@okaycj okaycj commented Nov 6, 2024

Summary

The exit URL was still interrupting the final Response update. This PR uses Promise's "Then"s to make the calls happen in order.

@okaycj okaycj requested a review from becky-gilbert November 6, 2024 17:03
Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: 6032a91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lookit/lookit-initjspsych Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@okaycj okaycj changed the base branch from main to sequence-error-logic November 6, 2024 17:03
Base automatically changed from sequence-error-logic to main November 6, 2024 18:27
@okaycj okaycj merged commit 0d02095 into main Nov 6, 2024
2 checks passed
@okaycj okaycj deleted the exit-url-fix branch November 6, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants