-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added nesting highlights, popup notes, and translation links. #3
base: main
Are you sure you want to change the base?
Conversation
Made the highlights nest spatially, which I think helps a little more. I think I'm done. Lemme know if there's anything that needs to be changed. |
@rlpowell ? Any plans to try it?
…On Sun, Jan 2, 2022, 15:39 Erhannis ***@***.***> wrote:
Made the highlights nest spatially, which I think helps a little more. I
think I'm done. Lemme know if there's anything that needs to be changed.
—
Reply to this email directly, view it on GitHub
<#3 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASNCENIA5AO7QPRQZXZMF3UUBBQVANCNFSM5LDTINRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Here's the before: and here's the after: I'm leaving the site up with Erhannis's version so people can look at it. I'm not a huge fan myself, I'm sorry to say. I don't like moving all the bits that make jbofihe unique into tooltips; it seems like it's trying too hard to be camxes.lojban.org . But even if we're going to do that, I definitely don't like the proliferation of asterisks; there's just a lot of them. I don't know what visual indicator of "there's a hidden tooltip here" I'd prefer, though. Having said all that, I'm happy to go with whatever other people prefer; I don't consider myself a gatekeeper here. |
Should definitely provide an option to choose between older and newer
versions.
…On Mon, Jan 3, 2022, 10:14 rlpowell ***@***.***> wrote:
Here's the before:
[image: image]
<https://user-images.githubusercontent.com/35904/147906464-35d8a45b-1c6b-425a-a273-2352405073c4.png>
and here's the after:
[image: image]
<https://user-images.githubusercontent.com/35904/147906525-4c705562-5eb3-4ee4-b881-02a72a984adb.png>
I'm leaving the site up with Erhannis's version so people can look at it.
I'm not a huge fan myself, I'm sorry to say. I don't like moving all the
bits that make jbofihe unique into tooltips; it seems like it's trying too
hard to be camxes.lojban.org . But even if we're going to do that, I
*definitely* don't like the proliferation of asterisks; there's just a
lot of them. I don't know what visual indicator of "there's a hidden
tooltip here" I'd prefer, though.
Having said all that, I'm happy to go with whatever other people prefer; I
don't consider myself a gatekeeper here.
—
Reply to this email directly, view it on GitHub
<#3 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASNCEPWEB7PDQ5ZHZTMHMDUUFEENANCNFSM5LDTINRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Ok; I've added a dropdown to switch between expanded and contracted mode. I've defaulted it to contracted mode, because, well, I'm biased. ;) BUT I can switch the default to the old way, if you'd prefer. I'll look again into moving the tooltips onto the words themselves - I'm not keen on spending a huge amount of time trying to parse html, so I'll probably only give it the next 45 min, but we'll see if I can figure anything out. |
…re it makes sense. I don't trust it will gracefully handle all feasible inputs, though, so I also added a 'condensed (robust)' mode.
Ok, I think I've figured out a way to move the tooltips onto words-to-be-translated, where such exist. Some tooltips are, e.g., notes about the role a word plays, or implied words, etc., so those I've left as asterisks. I had trouble with it at first because jbofihe sometimes omits a translation I also added a I can remove the |
Actually, speaking of the words that jbofihe doesn't translate - any idea why that is? I notice a lot of cv'v words aren't touched, like ji'a, la'e, de'e, and ze'u. In fact, it may be ONLY words of that form that are omitted, as far as I've seen. |
If it's a problem with the dictionary you may add glosses to it.
Em seg., 3 de jan. de 2022 às 17:56, Erhannis ***@***.***>
escreveu:
… Actually, speaking of the words that jbofihe doesn't translate - any idea
why that is? I notice a lot of cv'v words aren't touched, like ji'a, la'e,
de'e, and ze'u. In fact, it may be ONLY words of that form that are
omitted, as far as I've seen.
—
Reply to this email directly, view it on GitHub
<#3 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASNCEM7IKGAFTJN3DD7GR3UUG2LFANCNFSM5LDTINRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Can you deploy a staging env somewhere so that others can see without
disturbing Robin?
Em seg., 3 de jan. de 2022 às 17:52, Erhannis ***@***.***>
escreveu:
… Ok, I think I've figured out a way to move the tooltips onto
words-to-be-translated, where such exist. Some tooltips are, e.g., notes
about the role a word plays, or implied words, etc., so those I've left as
asterisks.
I had trouble with it at first because jbofihe sometimes omits a
translation <I> block entirely, which made the post-processed result all
gunked up. I don't entirely trust there not to be any more gotchas, so
while the word-tooltip change has been applied to the condensed mode,
I've also left the (IMO likely more robust) previous asterisked mode in as condensed
(robust), for use if normal condensed is gives weird results. I don't
KNOW of any input that would produce such output, though.
I also added a plain mode, returning the plain result of jbofihe, because
it was useful in debugging. It may not be useful to the average user,
though.
I can remove the plain and/or condensed (robust) modes, if you'd prefer.
—
Reply to this email directly, view it on GitHub
<#3 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASNCEOIOMXGPOWS5TCTCVLUUGZ35ANCNFSM5LDTINRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Ok; I've started a server on http://18.237.58.79:8080/ . I can give it a proper url if needed; not sure what your intended purpose is. |
Em ter., 4 de jan. de 2022 às 03:59, Erhannis ***@***.***>
escreveu:
Ok; I've started a server on http://18.237.58.79:8080/ . I can give it a
proper url if needed; not sure what your intended purpose is.
The purpose is to avoid experimenting with production and discuss
improvements in a separate enviroment.
I'm not sure what could be the best option here. Maybe
1. replace the select menu with three buttons
2. use cookies to remember last selection
3. use the old method as the default selection (when no cookies)
On a separate note what about mobile screen optimization?
… —
Reply to this email directly, view it on GitHub
<#3 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASNCEMWICTUJDXJJE6B67LUUJA6FANCNFSM5LDTINRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
The output showed a lot of useful-looking information, but in a form that was hard to grasp.
So I added transparent colored backgrounds by ()/[]/<> to visually show nesting,
moved the translations to hover-over tooltips,
and made the lojban words link to sutysisku for a full translation.
The highlights are a bit garish, and maybe not as easy-to-understand as they could be, but I'm not immediately sure how to improve them.
I did just have a thought, though, so I'll probably push another commit in a minute.
The colors will likely remain garish, though.
Do you think there should be a checkbox to toggle between the old/new modes, or anything?
Testing it on a few sentences of text, I do feel like the new interface significantly improves understandability.