Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait 2sec before NewTasksRunningWaiter #94

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

juri-t
Copy link
Contributor

@juri-t juri-t commented Oct 22, 2024

fix #93

To resolve the issue where ecs.NewTasksRunningWaiter fails when executed too early, I added a 2-second delay before running it.

@juri-t juri-t self-assigned this Oct 22, 2024
@juri-t juri-t requested a review from takkyuuplayer October 22, 2024 07:36
Copy link
Contributor

@takkyuuplayer takkyuuplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.96%. Comparing base (8251f32) to head (76003ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   88.35%   85.96%   -2.39%     
==========================================
  Files          21       21              
  Lines        1065     1240     +175     
==========================================
+ Hits          941     1066     +125     
- Misses         61      111      +50     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juri-t juri-t merged commit 5f25dc5 into main Oct 22, 2024
2 of 3 checks passed
@juri-t juri-t deleted the wait-for-tasks-running branch October 22, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes waitForTaskRunning in actions-deploy-cage fails
2 participants