Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add remote_ip to example configuration #250

Closed
wants to merge 1 commit into from

Conversation

jakelandis
Copy link
Contributor

Fixes #249

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@jakelandis
Copy link
Contributor Author

@acchen97 - Can you review the documentation change ?

I didn't see anywhere that we explicitly document the @metadata fields, so I just added it to the example.

How we document here should be similar to the TCP input which also has this value (as 5.0.0) logstash-plugins/logstash-input-tcp#81

@acchen97
Copy link

@jakelandis thanks for this. It might make sense to have a brief annotation for this. Thoughts around the below?

Incoming events from Beats include metadata information around the IP address of the host the Beat collected the event from. For example, this field can be accessed and enriched in the core event:

filter {
  mutate {
    add_field => { "remote_ip" => "%{[@metadata][ip_address]}" }
  }
}

@acchen97
Copy link

@jakelandis FYI, nice example from @suyograo on the Kafka plugin: logstash-plugins/logstash-input-kafka@cac9d59

@jsvd
Copy link
Member

jsvd commented Dec 22, 2017

this looks like a quick win for improving users' experience and understanding, poking @jakelandis so this doesn't get stale

@Toffs-Rocky
Copy link

When I add this config, most events can get ip address, but some events show this value “%{[@metadata][ip_address]}”. Anyone encountered this problem?

@jakelandis
Copy link
Contributor Author

closing this PR as stale

@jakelandis jakelandis closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Remote IP
4 participants