Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: replace cgo implements sqlite persistence driver with pure-go implements sqlite driver #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enhance: replace cgo implements sqlite persistence driver with pure-go implements sqlite driver #673

wants to merge 1 commit into from

Conversation

gqcn
Copy link

@gqcn gqcn commented Apr 11, 2024

Replace cgo implements sqlite driver github.com/mattn/go-sqlite3 with pure-go implements sqlite driver github.com/glebarez/go-sqlite.

Proposed Changes:

  • pkg/util/persistence/driver

Which issue(s) this PR fixes:

No fix, but an enhancement.

Additional documentation:

The cgo driver is ugly, that makes cross-building complicated.

@gqcn
Copy link
Author

gqcn commented Apr 11, 2024

@ethfoo @mmaxiaolei @OliverWoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gqcn