Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jpeg exif parser #4941

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

oh6hay
Copy link

@oh6hay oh6hay commented Dec 12, 2024

One line description of pull request

Add a JPEG EXIF parser

Description:

Parses basic EXIF data from JPEG images. It seems introducing new dependencies isn't exactly encouraged due to possible license compatibility issues so I made a quick&dirty inline jpeg parser.

Notes:

All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.

Checklist:

  • Automated checks (GitHub Actions, AppVeyor) pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned

@joachimmetz
Copy link
Member

Thanks for the proposed changes, please take a look at the style guide https://plaso.readthedocs.io/en/latest/sources/developer/Style-guide.html and please change the PR to align with that style

@oh6hay
Copy link
Author

oh6hay commented Dec 13, 2024

hi @joachimmetz , the style guide is rather concise, could you kindly point towards any discrepancies?

@joachimmetz
Copy link
Member

I'll take a closer look when time permits. In the meantime I recommend to have a look at similar parsers in Plaso. Unfortunately the style deviates from that at the moment, so merging the code might take a significant time (due to limited bandwidth on my end)

@oh6hay
Copy link
Author

oh6hay commented Dec 14, 2024

thanks @joachimmetz I'll have a look at other parsers. Are contributions to the style guide also welcome, to better define all aspects of the code and style conventions?

@joachimmetz
Copy link
Member

joachimmetz commented Dec 14, 2024

Are contributions to the style guide also welcome, to better define all aspects of the code and style conventions?

They are. But realize though that some of the style decision are historical and we prefer to try to keep the code mostly in the same style. So making changes such as adoptions of f-strings or type hints takes time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants