Firefox download update #4749
Merged
Firefox download update #4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4749 +/- ##
==========================================
+ Coverage 86.15% 86.16% +0.01%
==========================================
Files 416 416
Lines 37526 37574 +48
==========================================
+ Hits 32329 32376 +47
- Misses 5197 5198 +1 ☔ View full report in Codecov by Sentry. |
joachimmetz
reviewed
Oct 7, 2023
| @@ -2,7 +2,7 @@ | |||
| """SQLite parser plugin for Mozilla Firefox downloads database files.""" | |||
|
|
|||
| from dfdatetime import posix_time as dfdatetime_posix_time | |||
|
|
|||
| import json | |||
There was a problem hiding this comment.
style nit: given this module is part of Python the import should come before 3rd party imports
joachimmetz
reviewed
Oct 7, 2023
| @@ -133,3 +277,4 @@ def ParseDownloadsRow( | |||
|
|
|||
|
|
|||
| sqlite.SQLiteParser.RegisterPlugin(FirefoxDownloadsPlugin) | |||
joachimmetz
reviewed
Oct 7, 2023
| self.url = None | ||
|
|
||
|
|
||
| class Firefox118DownloadsPlugin(interface.SQLitePlugin): |
joachimmetz
force-pushed
the
firefox_download_update
branch
from
8e66de9 to
0a0ab98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line description of pull request
Firefox Download plugin was out of date, so I updated
Description:
Firefox schema has changed significantly since this parser(plugin) was written. This handles #2539
Notes:
Checklist: