Add var-name sub linter in revive (milvus-io#27424)

Signed-off-by: Congqi Xia <[email protected]>
locustbaby · Oct 7, 2023 · cd5f03f · cd5f03f
1 parent 5c1abfa
commit cd5f03f
Show file tree

Hide file tree

Showing 6 changed files with 132 additions and 125 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -48,6 +48,11 @@ linters-settings:
     rules:
       - name: unused-parameter
         disabled: true
+      - name: var-naming
+        severity: warning
+        disabled: false
+        arguments:
+          - ["ID"] # Allow list
   misspell:
     locale: US
   gocritic:

diff --git a/internal/datacoord/server_test.go b/internal/datacoord/server_test.go
@@ -4167,7 +4167,7 @@ func TestDataCoordServer_UpdateChannelCheckpoint(t *testing.T) {
 	})
 }
 
-var global_test_tikv = tikv.SetupLocalTxn()
+var globalTestTikv = tikv.SetupLocalTxn()
 
 func newTestServer(t *testing.T, receiveCh chan any, opts ...Option) *Server {
 	var err error
@@ -4188,7 +4188,7 @@ func newTestServer(t *testing.T, receiveCh chan any, opts ...Option) *Server {
 
 	svr := CreateServer(context.TODO(), factory)
 	svr.SetEtcdClient(etcdCli)
-	svr.SetTiKVClient(global_test_tikv)
+	svr.SetTiKVClient(globalTestTikv)
 
 	svr.dataNodeCreator = func(ctx context.Context, addr string, nodeID int64) (types.DataNodeClient, error) {
 		return newMockDataNodeClient(0, receiveCh)
@@ -4242,7 +4242,7 @@ func newTestServerWithMeta(t *testing.T, receiveCh chan any, meta *meta, opts ..
 
 	svr := CreateServer(context.TODO(), factory, opts...)
 	svr.SetEtcdClient(etcdCli)
-	svr.SetTiKVClient(global_test_tikv)
+	svr.SetTiKVClient(globalTestTikv)
 
 	svr.dataNodeCreator = func(ctx context.Context, addr string, nodeID int64) (types.DataNodeClient, error) {
 		return newMockDataNodeClient(0, receiveCh)
@@ -4299,7 +4299,7 @@ func newTestServer2(t *testing.T, receiveCh chan any, opts ...Option) *Server {
 
 	svr := CreateServer(context.TODO(), factory, opts...)
 	svr.SetEtcdClient(etcdCli)
-	svr.SetTiKVClient(global_test_tikv)
+	svr.SetTiKVClient(globalTestTikv)
 
 	svr.dataNodeCreator = func(ctx context.Context, addr string, nodeID int64) (types.DataNodeClient, error) {
 		return newMockDataNodeClient(0, receiveCh)
@@ -4495,7 +4495,7 @@ func testDataCoordBase(t *testing.T, opts ...Option) *Server {
 
 	svr := CreateServer(ctx, factory, opts...)
 	svr.SetEtcdClient(etcdCli)
-	svr.SetTiKVClient(global_test_tikv)
+	svr.SetTiKVClient(globalTestTikv)
 
 	svr.SetDataNodeCreator(func(ctx context.Context, addr string, nodeID int64) (types.DataNodeClient, error) {
 		return newMockDataNodeClient(0, nil)

diff --git a/internal/kv/tikv/main_test.go b/internal/kv/tikv/main_test.go
@@ -80,8 +80,8 @@ func setupRemoteTiKV() {
 	}
 }
 
-func setupTiKV(use_remote bool) {
-	if use_remote {
+func setupTiKV(useRemote bool) {
+	if useRemote {
 		setupRemoteTiKV()
 	} else {
 		setupLocalTiKV()