-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Search and Replace #77
Conversation
Theoretically, you shouldn't have to do anything, it will be handled as if the user replaced the text manually. |
Resolved the merge conflict and changed the svgs to components.
Either I'm stupid, or it doesn't. |
Sorry, I mean after #66 is merged. The current undo stack only supports changes made at the end of the prompt. |
I got around to reviewing this PR, and the code looks good to me. However, I have some suggestions for the UI:
Also, I see what you did with the placeholders, quite controversial lol. It's fine though, I won't pick on your creative choices. |
…xt' text, adjusted widget width
Put in the requested adjustments. |
My vocaloid knowledge is severely lacking, but this should do. |
Okay, this looks good to merge, I think there are still a few things that could be improved, but I guess they could be done in other commits/PRs as needed. Thank you for the contribution! :) |
Feel free to let me know what the issues are exactly. |
@neCo2 The only thing I would call an "issue" is how the widget resizes with the window size, becoming too big on an ultra-wide screen: I guess this was my fault for suggesting The other improvements I was considering include:
In other words, features that are in the find/replace of softwares like VSCode: |
Adding a search and replace function. Currently accessible via a button below the editor preferences button.
The UI for search and replace uses a draggable component. The "active" surface for that is the darkened area with the title.
Right now, it can do plaintext and regex replacements. I want to add template replacements too, but maybe I should wait for your chat completions PR for that one.