Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm15: enable ptr type #30

Closed
wants to merge 1 commit into from
Closed

llvm15: enable ptr type #30

wants to merge 1 commit into from

Conversation

dannypsnl
Copy link
Member

@dannypsnl dannypsnl commented Oct 23, 2022

NOTE: I ensure 15.0.3 enable this type

By the way, I tested several conflict things in ANTLR and still failed to handle cases, sadly.

Signed-off-by: Lîm Tsú-thuàn <[email protected]>
@dannypsnl dannypsnl requested a review from mewmew October 23, 2022 17:32
@mewmew
Copy link
Member

mewmew commented Oct 23, 2022

Hi @dannypsnl,

By the way, I tested several conflict things in ANTLR and still failed to handle cases, sadly.

Glad you are trying ANTRL out, even if the test didn't work out. Should it be able to produce a better parser that handles ambiguities better than the Textmapper one, we can consider switching.

Regarding this PR, as mentioned in llir/llvm#222 (comment) I am quite busy at Uni for the next few months. Usually Autumn is a busy time for me : )

Should you feel like, then continue working on the llvm15 branch.

Once I get more time available, I can review your work; after which we can merge into master. You can also create an llvm15 branch of the testdata repo if you wish.

Wish you all the best and a happy Autumn!

Cheers,
Robin

@dannypsnl
Copy link
Member Author

close for now

@dannypsnl dannypsnl closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants