Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cooler zoomify #15

Merged
merged 7 commits into from
Apr 2, 2024
Merged

Add cooler zoomify #15

merged 7 commits into from
Apr 2, 2024

Conversation

tbrown91
Copy link
Contributor

Hello,

We would like to include the zoomify function from cooler to be able to view these in higlass. I have made an initial effort on this front, but maybe you would prefer to change it to your specs.

All the best,

Tom

tools/cooler/cooler_zoomify.xml Outdated Show resolved Hide resolved
tools/cooler/cooler_zoomify.xml Outdated Show resolved Hide resolved
tools/cooler/cooler_zoomify.xml Outdated Show resolved Hide resolved
tools/cooler/cooler_zoomify.xml Outdated Show resolved Hide resolved
tools/cooler/cooler_zoomify.xml Outdated Show resolved Hide resolved
@tbrown91
Copy link
Contributor Author

thanks Björn, I think this is what I'm after.

I'm just a little nervous as I can't get planemo running on my laptop and don't see the checks running

@bgruening
Copy link

You are a new contributor and github prevents CI runs for them, security ...

Feel free to let me know why planemo is not running for you via chat.

@tbrown91
Copy link
Contributor Author

I am getting the following linting error, which I don't understand when compared to other xmls in this suite:

.. ERROR: Invalid XML found in file: cooler_zoomify.xml. Errors [/var/folders/gf/k37ckmns0lx_fryk50s01j9h0000gq/T/tmp2428wkkl:33:0:ERROR:SCHEMASV:SCHEMAV_CVC_COMPLEX_TYPE_3_2_1: Element 'data', attribute 'type': The attribute 'type' is not allowed.]

@tbrown91
Copy link
Contributor Author

... I found it

@tbrown91
Copy link
Contributor Author

I think this is good to go now. I passed the planemo tests and don't think I did anything too controversial

@bgruening
Copy link

Thanks @tbrown91!

@lldelisle
Copy link
Owner

Hi,
I've just launched the CI. Tell me it passes.

@lldelisle
Copy link
Owner

Hi,
It seems you added to the repo a input.mcool which is not used. Is it normal? It seems that you use the 'input.cool' that I put.

@tbrown91
Copy link
Contributor Author

ah, you're right. I think I created this in one of my initial tests. I will remove it

@lldelisle
Copy link
Owner

In the current test, it is not adding any resolution, here is the standard error:

INFO:cooler.cli.zoomify:Recursively aggregating "/tmp/tmpvf9z3tb7/files/5/6/b/dataset_56b365ac-4545-40dc-9db7-38908595e4b3.dat"
INFO:cooler.cli.zoomify:Writing to "/tmp/tmpvf9z3tb7/job_working_directory/000/2/outputs/dataset_376f04ff-763d-4065-bcd9-aa1fb9f49ec8.dat"
INFO:cooler.reduce:Copying base matrices and producing 1 new zoom levels.
INFO:cooler.reduce:Bin size: 1000000

Can you add another test with for example resolution 1000000,2000000,10000000?

@lldelisle
Copy link
Owner

I forgot to tell you that I am super happy that you are contributing (I am really rude, I should have started by this).

@tbrown91
Copy link
Contributor Author

tbrown91 commented Apr 1, 2024

no worries.

See what you think

@lldelisle lldelisle merged commit bee0809 into lldelisle:master Apr 2, 2024
13 checks passed
@lldelisle
Copy link
Owner

Perfect. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants