Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for knex template migration errors #244

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

roycechua
Copy link

Content (작업 내용) 📝

Minor PR for the template created with knex

  1. Fix for knex migration error - missing client configuration error
  2. Fix for invalid migration file error - must have both an up and down function

Screenshot for work content (작업 내용 스크린샷) 📸

Fixes for the following errors on initial migration from newly generated template using knex

Screenshot 2024-02-27 at 9 17 29 PM

Screenshot 2024-02-27 at 9 17 49 PM

After PR

Screenshot 2024-02-27 at 9 18 06 PM

Links (링크) 🔗

Check List (체크 사항) ✅

  • Issue (이슈)
  • Tests (테스트)
  • Ready to be merged (병합 준비 완료)
  • Added myself to contributors table (기여자 추가)

@eboujobe
Copy link

eboujobe commented Mar 9, 2024

@ljlm0402 can we please have this PR in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants