task: Make 4xx errors from Catalyst unretriable (#175)

* task: Make 4xx errors from Catalyst unretriable

This is to improve our error classification and both
not retry as well as not alert from user-input errors
on the request to Catalyst (normally bad input URLs).

* clients: Remove error forcing, return RateLimited instead

clients/catalyst.go

@@ -164,3 +164,9 @@ func isTooManyRequestsErr(err error) bool {
 	var statusErr *HTTPStatusError
 	return errors.As(err, &statusErr) && statusErr.Status == http.StatusTooManyRequests
 }
+
+func IsInputError(err error) bool {
+	var statusErr *HTTPStatusError
+	return errors.As(err, &statusErr) &&
+		(statusErr.Status >= 400 && statusErr.Status < 500)
+}

task/upload.go

@@ -83,6 +83,8 @@ func handleUploadVOD(p handleUploadVODParams) (*TaskHandlerOutput, error) {
 		err = tctx.catalyst.UploadVOD(ctx, req)
 		if errors.Is(err, clients.ErrRateLimited) {
 			nextStep = "rateLimitBackoff"
+		} else if clients.IsInputError(err) {
+			return nil, UnretriableError{fmt.Errorf("input error on catalyst request: %w", err)}
 		} else if err != nil {
 			return nil, fmt.Errorf("failed to call catalyst: %w", err)
 		}