Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-ai: Update to use FLV-enabled LPMS #3288

Merged
merged 3 commits into from
Dec 3, 2024
Merged

live-ai: Update to use FLV-enabled LPMS #3288

merged 3 commits into from
Dec 3, 2024

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Dec 3, 2024

What does this pull request do? Explain your changes. (required)

Updates LPMS to use the FLV muxer introduced in livepeer/lpms#428 which should resolve issues with getting RTMP output.

Specific updates (required)

How did you test each of these updates (required)

Manually tested a production LPMS build with and without the FLV muxer.

@j0sh j0sh requested review from victorges, leszko and mjh1 December 3, 2024 00:34
@github-actions github-actions bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 34.48947%. Comparing base (baf0383) to head (9981665).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_live_video.go 0.00000% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3288         +/-   ##
===================================================
+ Coverage   34.48597%   34.48947%   +0.00350%     
===================================================
  Files            137         137                 
  Lines          36496       36501          +5     
===================================================
+ Hits           12586       12589          +3     
- Misses         23194       23196          +2     
  Partials         716         716                 
Files with missing lines Coverage Δ
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4423254...9981665. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes

@j0sh j0sh merged commit 302a4e2 into master Dec 3, 2024
18 checks passed
@j0sh j0sh deleted the ja/lpms-flv branch December 3, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. dependencies Pull requests that update a dependency file docker Pull requests that update Docker code go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants