mediamtx: Publish deployed version if runtime args are present #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docker
hjpotter92
force-pushed
the
hjp/mediamtx
branch
from
a8022c1 to
400c8bf
Compare
pwilczynskiclearcode
approved these changes
Nov 29, 2024
| set -euo pipefail | ||
|
|
||
| if [ -v LP_PUBLISH_MEDIAMTX_METRICS ]; then | ||
| if [ -z "$LP_PUBLISH_MEDIAMTX_METRICS_ENDPOINT" ]; then |
There was a problem hiding this comment.
Should we exit if the endpoint is not specified?
if [ -z "$LP_PUBLISH_MEDIAMTX_METRICS_ENDPOINT" ]; then
echo >&2 "No endpoint specified for publishing mediamtx metrics."
exit 1
fiThere was a problem hiding this comment.
i was thinking it more as a warning than a fail condition.
There was a problem hiding this comment.
if LP_PUBLISH_MEDIAMTX_METRICS_ENDPOINT is missing then curl would fail few lines below.
But yeah warning is fine... I think we'd catch it missing anyway as not having mediamtx version on grafana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparing the image so that container can optionally inject version metrics to prometheus/victoriametrics at runtime.