Merge pull request #3341 from livepeer/pawel/eng-2342-add-stream-star… #2633
Annotations
11 warnings
|
Run Revive Action by building from repository:
trickle/trickle_subscriber.go#L16
error var EOS should have name of the form ErrFoo
|
|
Run Revive Action by building from repository:
trickle/trickle_publisher.go#L114
should replace c.index += 1 with c.index++
|
|
Run Revive Action by building from repository:
trickle/trickle_publisher.go#L143
exported method Next returns unexported type *trickle.pendingPost, which can be annoying to use
|
|
Run Revive Action by building from repository:
media/mediamtx.go#L47
func getApiPath should be getAPIPath
|
|
Run Revive Action by building from repository:
media/rtmp2segment.go#L177
should drop = nil from declaration of var currentSegment; it is the zero value
|
|
Run Revive Action by building from repository:
media/rtmp2segment.go#L240
parameter 'ctx' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action by building from repository:
media/rtmp2segment.go#L240
parameter 'pipeName' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action by building from repository:
media/rw.go#L101
should drop = nil from declaration of var err; it is the zero value
|
|
Run Revive Action by building from repository:
media/segment_reader.go#L10
parameter 'reader' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action by building from repository:
media/segment_reader.go#L16
parameter 'p' seems to be unused, consider removing or renaming it as _
|
|
Upload coverage reports
Unexpected input(s) 'gcov_ignore', valid inputs are ['token', 'codecov_yml_path', 'commit_parent', 'directory', 'disable_file_fixes', 'disable_search', 'disable_safe_directory', 'dry_run', 'env_vars', 'exclude', 'fail_ci_if_error', 'file', 'files', 'flags', 'git_service', 'handle_no_reports_found', 'job_code', 'name', 'network_filter', 'network_prefix', 'os', 'override_branch', 'override_build', 'override_build_url', 'override_commit', 'override_pr', 'plugin', 'plugins', 'report_code', 'root_dir', 'slug', 'url', 'use_legacy_upload_endpoint', 'use_oidc', 'verbose', 'version', 'working-directory']
|
Loading