Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate numeral to numbro #242

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rickstaa
Copy link
Member

@rickstaa rickstaa commented Dec 12, 2023

This pull request deprecates the use of the unmaintained numeral-js library and replaces it with the numbro. This was done to fix #236 and ensure the explorer is future-proof.

Warning

Replacement for #237, which, had to be reverted since it broke parts of the interface.

rickstaa and others added 2 commits December 3, 2023 16:16
This commit deprecates the use of the unmaintained
[numeral-js](https://github.com/adamwdraper/Numeral-js) library and
replaces it with the [numbro](https://github.com/BenjaminVanRyseghem/numbro).
This was done to fix livepeer#236 and ensure the explorer is future-proof.
Co-authored-by: Chase Adams <[email protected]>
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
explorer-arbitrum-goerli ✅ Ready (Inspect) Visit Preview Dec 12, 2023 8:18pm
explorer-arbitrum-one ✅ Ready (Inspect) Visit Preview Dec 12, 2023 8:18pm

Copy link

vercel bot commented Dec 12, 2023

@rickstaa is attempting to deploy a commit to the Livepeer Team on Vercel.

A member of the Team first needs to authorize it.

@rickstaa rickstaa changed the title migrate numeral to numbro feat: migrate numeral to numbro Dec 12, 2023
@rickstaa rickstaa marked this pull request as draft December 12, 2023 20:18
@rickstaa
Copy link
Member Author

rickstaa commented Dec 12, 2023

I have not yet confirmed if these changes are effective for the following sections of the explorer:

  1. Protocol Overview Widget: The left part of this widget fails to load due to an internal server error thrown by the /usage endpoint. It appears that I may need to provide the LIVEPEER_COM_API_ADMIN_TOKEN token.

Protocol Overview Widget

Protocol Overview Widget Error

  1. On-chain related widgets: I am still working on finding a way to test the widgets used for making on-chain requests, such as transferring LPT and voting.

I have added my current development process below.


Contributing

Development Process

  1. Clone the repository.

  2. Install dependencies using yarn.

  3. Rename the .env.example file to .env.

  4. Add the required variables to the .env file:

    NEXT_PUBLIC_INFURA_KEY= 
    NEXT_PUBLIC_SUBGRAPH_API_KEY=
    NEXT_PUBLIC_SUBGRAPH_ID=
    NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID=
  5. Set NEXT_PUBLIC_VERCEL_ENV to production within the .env file.

  6. Start the development server with the yarn dev command.

Note

Alternatively, you can use yarn build & yarn start if you prefer not to set NEXT_PUBLIC_VERCEL_ENV to production."

@adamsoffer adamsoffer requested a review from 0xcadams February 19, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delegated stake NaN display bug
1 participant