Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner/live: Ignore keepalive messages from control subscriber #313

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

j0sh
Copy link
Contributor

@j0sh j0sh commented Dec 5, 2024

The control channel only sees sporadic messages, so the publisher will send down a keepalive periodically to prevent clients from timing out and to prevent the server from sweeping idle channels.

Needed for livepeer/go-livepeer#3296 and livepeer/go-livepeer#3299

The control channel only sees sporadic messages, so the publisher
will send down a keepalive periodically to prevent clients from
timing out and to prevent the server from sweeping idle channels.
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@j0sh j0sh merged commit 481d075 into main Dec 6, 2024
9 checks passed
@j0sh j0sh deleted the ja/control-keepalive branch December 6, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants