Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Picker): Visibility callbacks, controlled mode; placement prop #994

Merged
merged 99 commits into from
Feb 1, 2024
Merged

fix(Picker): Visibility callbacks, controlled mode; placement prop #994

merged 99 commits into from
Feb 1, 2024

Conversation

VadymBezpalko
Copy link
Contributor

@VadymBezpalko VadymBezpalko commented Jan 31, 2024 •
edited
Loading

Resolves: #993

Description

Fixes/improvements:

  • onOpen/onClose callbacks
  • controlled mode (new isVisible prop)
  • new placement prop

Storybook

https://feature-993--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

VadymBezpalko and others added 30 commits November 2, 2023 14:03
@VadymBezpalko
feat(Popover): refactor component using floating-ui
2769557
@VadymBezpalko
feat(Popover): story styles
a723989
@VadymBezpalko
feat(Popover): story styling fix
f6afd53
@VadymBezpalko
feat(Popover): improving types
a47530f
@VadymBezpalko
feat(Popover): additional props
1e0ef4b
@VadymBezpalko
feat(Popover): tests
d427696
@VadymBezpalko
feat(Popover): review fixes
03341b9
@VadymBezpalko
Merge branch 'main' into feature/874
e5ffc86
@VadymBezpalko
feat(Picker):
9ce6ff4
@VadymBezpalko
feat(Picker): separate PickerListComponent
dd0b8ed
@VadymBezpalko
feat(Picker): separated PickerListItem component
2f0ac4a
@VadymBezpalko
feat(Picker): separated PickerTrigger component
25fa227
@VadymBezpalko
Merge branch 'main' into feature/777
9d73a63
@VadymBezpalko
feat(Picker): multiple select WIP
14a24c7
@VadymBezpalko
feat(Picker): handle select improvements
361af1b
@VadymBezpalko
feat(Picker): improved list styles
ebc4849
@VadymBezpalko
feat(Picker): PickerTrigger component
a7a7f64
@VadymBezpalko
feat(Picker): PickerTriggerBody component
e7e2d5e
@VadymBezpalko
feat(Picker): handling select in different way
4c9a925
@VadymBezpalko
feat(Picker): keyboard nav fixes
cbe69b4
@VadymBezpalko
feat(Picker): removing typeahead
468ddaf
@VadymBezpalko
feat(Picker): group header WIP
a336ef1
@VadymBezpalko
feat(Picker): set list to have the same width as trigger
ea05616
@VadymBezpalko
feat(Picker): group header styles fix
9e79e11
@VadymBezpalko
feat(Picker): onselect and onremove improvement
d455f3d
@VadymBezpalko
feat(Picker): onremove improvement
b8f7f37
@VadymBezpalko
feat(Picker): autocomplete
56f89f3
@VadymBezpalko
feat(Picker): using item keys instead of indexes
ed67728
@VadymBezpalko
feat(Picker): applying className and id props
9d2a765
@VadymBezpalko
feat(Picker): adding disabled item styles
52f38cb
@VadymBezpalko VadymBezpalko added the bug Something isn't working label Jan 31, 2024
@VadymBezpalko VadymBezpalko self-assigned this Jan 31, 2024
@VadymBezpalko VadymBezpalko changed the base branch from main to feature/777-picker-refactor January 31, 2024 14:56
@VadymBezpalko VadymBezpalko mentioned this pull request Feb 1, 2024
Closed
@VadymBezpalko VadymBezpalko added the feature New feature or request label Feb 1, 2024
@VadymBezpalko VadymBezpalko added this to the v1.0 milestone Feb 1, 2024
@VadymBezpalko VadymBezpalko marked this pull request as ready for review February 1, 2024 12:15
@VadymBezpalko VadymBezpalko changed the title fix(Picker): Various fixes fix(Picker): Visibility callbacks, controlled mode; placement prop Feb 1, 2024
@VadymBezpalko VadymBezpalko linked an issue Feb 1, 2024 that may be closed by this pull request
Picker - callback for the picker opening/closing and placement prop, z-index control #993
Closed
ashbork
ashbork approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ashbork ashbork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

Base automatically changed from feature/777-picker-refactor to main February 1, 2024 14:14
@VadymBezpalko
Merge branch 'main' into feature/993
8cf0592 
# Conflicts:
#	packages/react-components/src/components/Picker/Picker.tsx
#	packages/react-components/src/components/Picker/hooks/useFloatingPicker.ts
@VadymBezpalko VadymBezpalko merged commit a7eb9e1 into main Feb 1, 2024
5 checks passed
@VadymBezpalko VadymBezpalko deleted the feature/993 branch February 1, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladko-uxds vladko-uxds vladko-uxds approved these changes

@ashbork ashbork ashbork approved these changes

@marcinsawicki marcinsawicki Awaiting requested review from marcinsawicki

Assignees

@VadymBezpalko VadymBezpalko

Labels
bug Something isn't working feature New feature or request
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Picker - callback for the picker opening/closing and placement prop, z-index control
3 participants
@VadymBezpalko @ashbork @vladko-uxds